Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSProcessing] Enforce re-order for node label processing during classification #1136

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[GSProcessing] Enforce re-order for node label processing during classification #1136

merged 4 commits into from
Jan 29, 2025

Conversation

thvasilo
Copy link
Contributor

@thvasilo thvasilo commented Jan 17, 2025 •
edited
Loading

Issue #, if available:

Fixes #1135
Fixes #1138

Description of changes:

  • We guarantee ordering for node label classification by ordering the transformed label DF after processing by the NODE_INT_MAPPING id, and doing the same for masks.
  • Because there is no guarantee for order when writing to Parquet from Spark even for ordered Spark DataFrames, we collect the labels and masks to a Pandas DF on the Spark leader, and write that using pyarrow.
  • NOTE: DistPart requires at least N files to be present for every node/edge type, where N is the number of requested partitions. So when writing back the masks and label we still use the number of incoming partitions to create as many files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thvasilo thvasilo added ready able to trigger the CI gsprocessing For issues and PRs related the the GSProcessing library 0.4.1 labels Jan 17, 2025
@thvasilo thvasilo force-pushed the reorder-node-ids branch 2 times, most recently from 4d0afcd to 865d943 Compare January 17, 2025 19:28
@thvasilo thvasilo marked this pull request as ready for review January 17, 2025 19:42
@thvasilo thvasilo requested a review from jalencato January 17, 2025 19:42
@thvasilo thvasilo self-assigned this Jan 17, 2025
@thvasilo thvasilo added this to the 0.4.1 release milestone Jan 17, 2025
@thvasilo thvasilo force-pushed the reorder-node-ids branch 2 times, most recently from 40b16f9 to 811f4b1 Compare January 17, 2025 21:19
jalencato
jalencato reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any performance number to compare between the built-in spark method and pandaUDF method?

...graphstorm_processing/data_transformations/dist_transformations/dist_label_transformation.py Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/distributed_executor.py Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/graph_loaders/dist_heterogeneous_loader.py Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/graph_loaders/dist_heterogeneous_loader.py Outdated Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/graph_loaders/dist_heterogeneous_loader.py Show resolved Hide resolved
@thvasilo thvasilo added the bug Something isn't working label Jan 22, 2025
jalencato
jalencato approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Let us keep an eye on further experiment.

graphstorm-processing/graphstorm_processing/config/label_config_base.py Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/repartition_files.py Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/graph_loaders/dist_heterogeneous_loader.py Show resolved Hide resolved
@thvasilo thvasilo merged commit 721e561 into awslabs:main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalencato jalencato jalencato approved these changes

Assignees

@thvasilo thvasilo

Labels
0.4.1 bug Something isn't working gsprocessing For issues and PRs related the the GSProcessing library ready able to trigger the CI
Projects
None yet
Milestone
0.4.1 release
2 participants
@thvasilo @jalencato